fix: Resolves a segmentation fault on macOS (ARM64) #3963
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous UMFPACK_ORDERING_BEST setting triggered external METIS calls that caused stack corruption due to library mismatch.
OmarDuran
requested review from
castelletto1,
rrsettgast and
victorapm
as code owners
rrsettgast
approved these changes
Feb 5, 2026
castelletto1
added
the
ci: run integrated tests
Contributor
|
Let's run integrated tests. |
OmarDuran
added
ci: run CUDA builds
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3963 +/- ##
===========================================
- Coverage 58.87% 58.87% -0.01%
===========================================
Files 1353 1353
Lines 112953 112955 +2
===========================================
- Hits 66504 66502 -2
- Misses 46449 46453 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@OmarDuran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous UMFPACK_ORDERING_BEST setting triggered external METIS calls that caused stack corruption due to library mismatch. This PR switches to UMFPACK_ORDERING_AMD to ensure stability on macOS (ARM64)